Re: [PATCH] U6715 16550A serial driver support

From: Greg KH
Date: Thu Aug 05 2010 - 19:05:17 EST


On Thu, Aug 05, 2010 at 12:22:06AM -0700, Andrew Morton wrote:
> On Thu, 5 Aug 2010 09:14:40 +0200 Philippe Langlais <philippe.langlais@xxxxxxxxxxxxxx> wrote:
>
> >
> > >>
> > > The patch adds these .set_termios hooks but doesn't actually use them
> > > for anything.
> > >
> > > The changelog doesn't tell us _why_ this was done (it should) and
> > > lacking any code to look at it's all a bit mysterious.
> > >
> > >
> > This feature is used in our U6715 8250 platform serial driver, to avoid
> > hack in 8250.c set_termios (Alan Cox requirement).
> > In this driver the input uart clock frequency depends on baud rate and
> > is computed in our set_termios override function.
> > The U6715 paltform serial patch has been submitted on linux-arm mailing
> > list,
> > and is ready to enter Russell King Linux tree.
>
> Oh.
>
> > More things to do ?
>
> Update the changelog to include this rather important information.
>
> As the patches are dependent, treat them as a single series. Russell
> can merge them both with Greg's ack or Greg can merge them both with
> Russell's ack.

I've dropped the patch from my tree, so send it through Russell's, with
the proper changelog change and:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/