Re: [PATCH] kconfig: fix make oldconfig

From: Justin P. Mattock
Date: Fri Aug 06 2010 - 02:01:57 EST

[PATCH] kconfig: fix make oldconfig

Linus wrote:
This seems to make "make oldconfig" a _lot_ more verbose than it
used to be. In a very annoying way.

I just did a quick git bisect. It's introduced by commit 4062f1a4c030
("kconfig: use long options in conf") by Sam Ravnborg. Apparently that
thing is totally buggy, and doesn't just change the option names, but
actively breaks them.

The old behaviour (from years ago) were reintroduced by accident.
Fix this so we are back to the version that are silent
if there is nothing to ask about.

Reported-by: Linus Torvalds<torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Sam Ravnborg<sam@xxxxxxxxxxxx>

Sorry for this regression. Dunno how I missed it.
I guess I only tested "silentoldconfig".

Following patch seems obviously correct but as I am on the way
out of the door I could not do much testing.


diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 010600e..274f271 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -599,12 +599,12 @@ int main(int ac, char **av)
case savedefconfig:
- case oldconfig:
case oldaskconfig:
rootEntry =&rootmenu;
input_mode = silentoldconfig;
/* fall through */
+ case oldconfig:
case listnewconfig:
case oldnoconfig:
case silentoldconfig:

Id like to be more useful with really hitting this, seems I was for a few moments, then something in there tripped and caused oldconfig to behave.. anyways only real evidence I have of hitting this is an fpaste of my shell output

Anyways applied your patch below, make oldconfig worked as is no:

make oldconfig
scripts/kconfig/conf -o arch/x86/Kconfig
# configuration written to .config

that I was hitting for some reason or another then all of a sudden disappeared.

Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at