Re: [PATCH 1/2] [BUGFIX] perf probe: Fix to copy the type for rawparameters

[Masami Hiramatsu]

Masami Hiramatsu wrote:
> Copy type field if it is for raw parameters.
> Without this fix, perf probe drops the type if user passes it
> for raw parameters (e.g. %ax:u32 will be converted to %ax).

Hi Arnaldo,

Could you pick these patches?

Thank you,

> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> 
>  tools/perf/util/probe-finder.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 840f1aa..b69d194 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -706,8 +706,12 @@ static int find_variable(Dwarf_Die *sp_die, struct probe_finder *pf)
>  		pf->tvar->value = strdup(pf->pvar->var);
>  		if (pf->tvar->value == NULL)
>  			return -ENOMEM;
> -		else
> -			return 0;
> +		if (pf->pvar->type) {
> +			pf->tvar->type = strdup(pf->pvar->type);
> +			if (pf->tvar->type == NULL)
> +				return -ENOMEM;
> +		}
> +		return 0;
>  	}
> 
>  	pr_debug("Searching '%s' variable in context.\n",
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/