Re: [RFC PATCH 4/9] mce: Add persistent events

[Peter Zijlstra]

On Fri, 2010-08-06 at 16:25 +0200, Borislav Petkov wrote:
> +static const struct file_operations perf_mce_fops = {
> +       .llseek         = no_llseek,
> +       .open           = mce_perf_open,
> +       .poll           = perf_poll,
> +       .unlocked_ioctl = perf_ioctl,
> +       .compat_ioctl   = perf_ioctl,
> +       .mmap           = perf_mmap,
> +       .fasync         = perf_fasync,
> +       .release        = perf_release,
> +}; 

I'd rather see this part of the persistent bits live in
kernel/perf_event.c, that way you don't need the previous patch either.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/