Re: [PATCH 2/2] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells

[Dan Williams]

On Fri, Aug 6, 2010 at 10:54 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> On Thu, Aug 5, 2010 at 12:30 AM, Linus Walleij
> <linus.ml.walleij@xxxxxxxxx> wrote:
>> 2010/8/5 Alessandro Rubini <rubini@xxxxxxxx>:
>>
>>>> Peter, Alessandro and Viresh especially: you will hopefully use this
>>>> driver for ARM refboards, Nomadik and SPEAr, can you provide
>>>> an Acked-by:?
>>>
>>> I'm sorry I can't test it these times, I must delay stuff to
>>> the last week of August.
>>
>> That's be a Tested-by: tag, Acked-by: was more about whether you
>> think it looks sane I believe, see Documentation/SubmittingPatches.
>
> We have the Acked-by from Viresh, Alessandro looks like he is
> interested in trying it out, the driver is self contained, marked
> experimental, and you have a track-record of fixing things up, so I'll
> include it with the idea it will be easier to fixup in-tree.

...except this version no longer compiles:

drivers/dma/amba-pl08x.c: In function 'dma_set_runtime_config':
drivers/dma/amba-pl08x.c:1399: error: 'struct dma_slave_config' has no
member named 'maxburst'
drivers/dma/amba-pl08x.c:1405: error: 'struct dma_slave_config' has no
member named 'addr'
drivers/dma/amba-pl08x.c:1408: error: 'struct dma_slave_config' has no
member named 'addr_width'
drivers/dma/amba-pl08x.c:1464: error: 'struct dma_slave_config' has no
member named 'addr_width'
drivers/dma/amba-pl08x.c:1464: error: 'struct dma_slave_config' has no
member named 'maxburst'

Fix that up and we can try to get it in the second half of the merge window.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/