Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver

From: Vadim Zaliva
Date: Sun Aug 08 2010 - 22:33:47 EST


I have tested the patch on device I had
I will have an access to it to retest later thus week. We can wait for my test to try to identify how my PowerBook is different from yours. Or you can roll the patch back.

--
Sent from my iPhone

On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

>
>>> My device is 05ac:020e "fountain", actually generates *signed* values,
>>> thus the patch completely breaks it.
>>
>> I think Ben might have the same issue. I guess we need per-touchpad
>> functions to read the data.
>
> Yup, I confirm, same deal. This patch completely breaks it on my
> powerbook (same USB ID)
>
> Should we revert the commit for now ?
>
> Cheers,
> Ben.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/