Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement

[Dave Hansen]

On Thu, 2010-08-05 at 12:28 +0300, Avi Kivity wrote:
> On 08/04/2010 10:13 AM, Lai Jiangshan wrote:
> > mmu_shrink() should attempt to free @nr_to_scan entries.
> >
> 
> This conflicts with Dave's patchset.
> 
> Dave, what's going on with those patches?  They're starting to smell.

The hardware and test rig that actually found the original scalability
problem is a bit contended with issues at the moment, so I've been
unable to get the original issue reproduced.

But, I think the patches should be able to stand on their own.  Even in
my testing, it's obvious that the shrinker code gets queries (via
nr_to_shrink=0) *way* more often than it's actually called upon to
shrink things.

Even if we have to come back with some more patches than this in the
future for the original problem that was found, we should feel confident
that this patch set is worthwhile and does some real, quantifiable good
on its own.

I'll go and immediately test that the first four patches in the series
are still behaving themselves in the way that I expect.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/