Re: [PATCH] x86: remove __phys_reloc_hide

[Namhyung Kim]

2010-08-10 (í), 09:05 +0200, Ingo Molnar:
> * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> 
> > We pass -fno-strict-overflow to the kernel now, which takes care of the
> > underlying problem, at least for current versions of gcc.  Unfortunately
> > we still have people who want to use very old gcc versions to compile
> > the kernel, so it's probably better to leave it in at least until we
> > formally kill off support for gcc 3.
> 
> Namhyung, mind sending a patch that adds a comment to __pa_symbol() to point 
> out the connection to -fno-strict-overflow and that it can be removed once all 
> supported versions of GCC understand -fno-strict-overflow?
> 
> That would make for one less piece of legacy voodoo code in the kernel ;-)
> 
> Thanks,
> 
> 	Ingo

No problem. :-) But before that, let me clarify this: It seems
-fno-strict-overflow is all about the signed arithmetic and
__pa_symbol() does unsigned one. Is it really matters here?


-- 
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/