Re: linux-next: build failure after merge of the cifs tree

From: Stephen Rothwell
Date: Thu Aug 12 2010 - 03:46:37 EST


Hi Steve,

On Wed, 11 Aug 2010 23:04:36 -0500 Steve French <smfrench@xxxxxxxxx> wrote:
>
> Are you sure that this is a valid config file? CONFIG_KEYS should be
> set if CONFIG_DNS_RESOLVER is set?

It is a ppc64_defconfig. It has:

# CONFIG_KEYS is not set
CONFIG_DNS_RESOLVER=y

CONFIG_NFS_USE_KERNEL_DNS just selects CONFIG_DNS_RESOLVER but there is
no dependency on CONFIG_KEYS (select does not care about the
dependencies of the selected config option).

> key.h looks like it is included in all arch in this path
>
> net/dns_resolver/dns_key.c includes
> include/keys/dns_resolver-type.h which includes
> include/linux/key-type.h which includes
> include/linux/key.h
>
> the line 258 "key_instantiate_and_link" error could occur if
> "CONFIG_KEYS" is not set in .config

Which t isn't.

> net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
> so ... CONFIG_KEYS should be set ....

See above. You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
CONFIG_KEYS ...

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature