Re: [git pull request] ACPI patches for 2.6.36.merge

[Andrew Morton]

On Sun, 15 Aug 2010 11:15:51 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sun, Aug 15, 2010 at 3:41 AM, Sedat Dilek <sedat.dilek@xxxxxxxxxxxxxx> wrote:
> > I pulled in release GIT-branch on top of 2.6.35-git16 (commit
> > 5d7cb157025b3b4852f38e6e5e97d06ef12c1d78)
> >
> > Â $ git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
> > release
> >
> > Unfortunately, the build breaks:
> >
> > [ build.log ]
> > drivers/acpi/power.c: In function âacpi_power_off_deviceâ:
> > drivers/acpi/power.c:252: error: ârefâ undeclared (first use in this function)
> 
> What the heck is going on? That thing cannot have been tested AT ALL.
> It comes from commit cfa806f05980 ("gcc-4.6: ACPI: fix unused but set
> variables in ACPI"), and there is no way that code has ever been
> compiled. There's no conditional compilation (except for not enabling
> ACPI at all), and the declaration of 'ref' that the commit removes is
> followed just a few lines later by the use.
> 
> So WTF?
> 
> I can merge this and fix it up, but I'm not going to. This thing
> should never have been sent to me. It clearly had no testing at all. I
> even looked at whether it could _possibly_ be some kind of odd "patch
> applied with fuzz at the wrong place" issue, but that looks impossible
> too (not to mention _still_ not being an excuse for not even trying to
> compile the thing).
> 
> I understand when people don't notice compile errors that don't happen
> for them (due to being architecture- or configuration-specific), but I
> really don't see how that could _ever_ have been the case here.
> 
> I see Andrew in the sign-off chain, which surprises me. Maybe he just
> passed on the patch blindly. But seriously, what the _hell_ is going
> on here?
> 

I'd be suspecting that we have two patches both of which worked
separately but which broke when combined.  Is there some other patch in
that tree which adds a new reference to `ref' in acpi_power_seq_show()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/