[PATCH] hwmon: (ads7871) Fix ads7871_probe error path

From: Axel Lin
Date: Sun Aug 15 2010 - 21:29:07 EST


We need to call hwmon_device_unregister() if an error is detected after
sucessfully register hwmon device.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
---
drivers/hwmon/ads7871.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index b300a20..303db92 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -201,11 +201,13 @@ static int __devinit ads7871_probe(struct spi_device *spi)
we need to make sure we really have a chip*/
if (val != ret) {
err = -ENODEV;
- goto error_remove;
+ goto error_unregister;
}

return 0;

+error_unregister:
+ hwmon_device_unregister(pdata->hwmon_dev);
error_remove:
sysfs_remove_group(&spi->dev.kobj, &ads7871_group);
error_free:
--
1.7.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/