RE: [PATCH 3/9] RapidIO: Add the ingress port number into the RIO switch data structure

From: Bounine, Alexandre
Date: Mon Aug 16 2010 - 09:42:54 EST


Micha Nelissen wrote:
>
> Alexandre Bounine wrote:
> > A switch ingress port number has to be saved for software assisted
error
> > recovery from the error-stopped state. Saving this information also
allows
> > to remove several register reads from the RIO enumeration process.
>
> Why not keep using the swpinfo field, as you can extract it from
there?
> And your code actually does this.
>
> Also processor devices can have multiple ports (not only switches), it
> would be good to be ready for that use case.
>
Agree. I missed the Multiport bit introduced in RIO spec 2.1. Now it is
justified to be as it was before.
I will rework this and next patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/