Re: [patch] pata_winbond: fix module init

From: Jeff Garzik
Date: Tue Aug 17 2010 - 13:39:29 EST


On 08/17/2010 06:07 AM, Alan Cox wrote:
On Tue, 17 Aug 2010 08:29:40 +0200
Dan Carpenter<error27@xxxxxxxxx> wrote:

On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:

Hi Dan,

On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
winbond_init_one() returns 0 on success and an error code on failure.
In the original code, we always just released the regions and return
-ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
Winbond support".

You might like to pick up

http://patchwork.ozlabs.org/patch/39358/

instead..


I don't have the hardware, but yes, probably it's better to replace this
driver since it has never been able to load.

It was obsoleted into pata_legacy before it was ever finalised -
unfortunately I could then not get Jeff to delete it.

Easy enough to delete now...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/