Re: Checkpatch false positive in 2.6.36-rc1.

From: Andy Whitcroft
Date: Wed Aug 18 2010 - 06:20:58 EST


On Wed, Aug 18, 2010 at 11:34:51AM +0530, Gopinath, Thara wrote:
> Hello Andy,
>
> The following is my patch.
>
> Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
> +++ linux-omap-pm/arch/arm/plat-omap/Kconfig
> @@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS
>
> config OMAP_SMARTREFLEX
> bool "SmartReflex support"
> - depends on ARCH_OMAP3 && PM
> + depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
> help
> Say Y if you want to enable SmartReflex.
>
>
> And the following is the check patch error I am getting
>
> WARNING: please write a paragraph that describes the config symbol fully
> #108: FILE: arch/arm/plat-omap/Kconfig:41:
> help

> total: 0 errors, 1 warnings, 67 lines checked

Yes that is a falsie. I think I have fixed it in my tree. Could you
test the version at the URL below and let me know if it works for you.

http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/