Re: [PATCH -v2 2/2] x86, cpu hotplug: Fix cpu bringup concurrencyissue

[H. Peter Anvin]

On 08/18/2010 12:28 PM, Borislav Petkov wrote:
>>
>> warning: (X86) selects ARCH_CPU_PROBE_RELEASE which has unmet direct
>> dependencies (HOTPLUG_CPU)
> 
> well I got 
> 
> +config ARCH_CPU_PROBE_RELEASE
> +       def_bool y
> +       depends on HOTPLUG_CPU
> 
> but I guess ARCH_CPU_PROBE_RELEASE gets selected still. Why isn't that
> "depends on" forcing it, I guess select is stronger.
> 
>> ... and build failure when compiling without CONFIG_HOTPLUG_CPU.
> 
> This hunk fixes the !CONFIG_HOTPLUG_CPU build here but I should've
> caught it earlier, shame on me. Sorry for the inconvenience, can you
> please drop this second patch for now, I'll send you a revised version
> tomorrow.
> 

I would prefer to not continue to have a piece of Kconfig code which
warns, so I'll hold off on this until I have your revised patch.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/