Re: [PATCH] kernel-doc: be case insensitive when removingattributes

From: Johannes Berg
Date: Thu Aug 19 2010 - 12:21:22 EST


On Thu, 2010-08-19 at 08:57 -0700, Randy Dunlap wrote:
> On Thu, 19 Aug 2010 16:13:42 +0200 Johannes Berg wrote:
>
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > There are valid attributes that could have upper
> > case letters, but we still want to remove, like
> > for example
> > __attribute__((aligned(NETDEV_ALIGN)))
> > as encountered in the wireless code.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> > ---
> > I thought we did this before? Bit confused now :)
>
> I have a similar patch, without patch description & signoff,
> so maybe it was from irc. Oh, and it's in a different script location.

Oh, ok.

> @@ -1426,6 +1426,7 @@ sub dump_struct($$) {
> $members =~ s/kmemcheck_bitfield_.*?;//gos;
> # strip attributes
> $members =~ s/__aligned\s*\(\d+\)//gos;
> + $members =~ s/__attribute__\s*\(\([a-zA-Z,_()\s\*]*\)\)//gos;
>
>
> If yours (below) does what is needed, that's fine with me.

Yes, it removes the warning for me.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/