Re: [PATCH] tmio_mmc: Allow 2 byte requests in 4-bit mode

From: Magnus Damm
Date: Fri Aug 20 2010 - 19:00:16 EST


On Tue, Jul 27, 2010 at 5:05 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
>> On 23 July 2010 12:05, Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
>>> 2010/7/20 Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx>:
>>>> Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit mode.
>>>> Tested with the SDHI hardware block included in sh7724.
>>>>
>>>> Signed-off-by: Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx>
>>>
>>> With this patch applied I can use SDIO cards in polling mode with the
>>> tmio-mmc driver. Tested with the SDHI hardware block on sh7372 using
>>> the b43 driver and BCM4318 hardware and the unfortunately out-of-tree
>>> AR6002 "android" driver.
>>>
>>> Acked-by: Magnus Damm <damm@xxxxxxxxxxxxx>
>>>

> On Tue, Jul 27, 2010 at 4:57 PM, Ian Molton <ian@xxxxxxxxxxxxxx> wrote:
>> This change needs to be modified to test what hardware is present.
>> this wont work on my hardware TTBOMK.
>
> Ok, just curious, on which platform did you test it?
>
> On SDHI hardware the 2-byte access works just fine in 4-bit mode.

Hi Ian,

Any update on this? I'd like to see this patch upstream since it
unbreaks SDIO support for platforms with SDHI controllers.

I have a BCM4318-based SDIO card that I can send with snail mail from
Japan if anyone is interested in testing on non-SDHI platforms.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/