Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

[Felipe Balbi]

Hi,

please break your lines at 80-characters. Also the [Hiremath, Vaibhav] 
is unnecessary.

On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote:
> > don't you need some locking on the irq handler ? a mutex maybe ? Just
> > wondering...
> [Hiremath, Vaibhav] Yes definitely we do need locking here, I thought 
> of adding locking mechanism in subsequent patch, does it makes sense?

so you add a buggy patch and fix it later ? If you already know it's 
buggy, why not changing the patch that adds the bug ?

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/