RE: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx]
> Sent: Monday, August 23, 2010 12:00 PM
> To: Hiremath, Vaibhav
> Cc: Balbi Felipe (Nokia-MS/Helsinki); linux-kernel@xxxxxxxxxxxxxxx;
> akpm@xxxxxxxxxxxxxxxxxxxx; byron.bbradley@xxxxxxxxx; linux-
> omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support
> 
> Hi,
> 
> please break your lines at 80-characters. 

Normally I do take care of this, but missed this time. I will be more careful in the future.

> Also the [Hiremath, Vaibhav]
> is unnecessary.
> 
> On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote:
> >> don't you need some locking on the irq handler ? a mutex maybe ? Just
> >> wondering...
> >>
> >[Hiremath, Vaibhav] Yes definitely we do need locking here, I thought
> >of adding locking mechanism in subsequent patch, does it makes sense?
> 
> so you add a buggy patch and fix it later ? If you already know it's
> buggy, why not changing the patch that adds the bug ?
> 
[Hiremath, Vaibhav] Nothing to argue here, I have to admit/accept and fix this.

Thanks,
Vaibhav

> --
> balbi
> 
> DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/