Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting

[Minchan Kim]

On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote:
> On Tue, 24 Aug 2010, Minchan Kim wrote
> 
> > This patch introude new argument 'cleanup' to migrate_pages.
> > Only if we set 1 to 'cleanup', migrate_page will clean up the lists.
> > Otherwise, caller need to clean up the lists so it has a chance to postprocess
> > the pages.
> 
> Could we simply make migrate_pages simply not do any cleanup?

If migrate_pages always return number of pages not migrated, it's possible.
But now it can return the number of pages not migrated or error code. 
In case of returning error code, caller has a complex routine to know count the 
number of success.

> Caller has to call putback_lru_pages()?
> 
Hmm. yes it's not good. At least we can help some NOTE.
migrate_pages isn't generic kernel API so i think documentation is enough. 

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/