Re: [patch 4/6] jbd: remove dependency on __GFP_NOFAIL

From: Andrew Morton
Date: Mon Aug 23 2010 - 18:11:45 EST


On Tue, 24 Aug 2010 00:03:47 +0200
Jan Kara <jack@xxxxxxx> wrote:

> So do
> you think that we should keep __GFP_NOFAIL as long as all callers are not
> able to handle allocation failures in more reasonable way?

The concept should be encapsulated in _some_ centralised fashion.

Helper functions would work as well as __GFP_NOFAIL, and will move any
runtime cost away from the good code and push it onto the bad code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/