Re: [KVM timekeeping 05/35] Move TSC reset out of vmcb_init

[Zachary Amsden]

On 08/20/2010 07:08 AM, Glauber Costa wrote:
> On Thu, Aug 19, 2010 at 10:07:19PM -1000, Zachary Amsden wrote:
>    
> > The VMCB is reset whenever we receive a startup IPI, so Linux is setting
> > TSC back to zero happens very late in the boot process and destabilizing
> > the TSC.  Instead, just set TSC to zero once at VCPU creation time.
> >
> > Why the separate patch?  So git-bisect is your friend.
> >
> > Signed-off-by: Zachary Amsden<zamsden@xxxxxxxxxx>
> >      
> Shouldn't we set for whatever value the BSP already has, and then the BSP to
> zero? Since vcpus are initialized at different times, this pretty much
> guarantees that the guest will have desynchronized tsc at all cases
> (not that if it was better before...)
>    

Yes, we should - but it takes a lot more machinery to do that, and so it 
happens later in the series.  You have to match the offsets for the BSP 
and other vcpus...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/