Re: [PATCH] s390: Fix prototype for execve

From: Heiko Carstens
Date: Wed Aug 25 2010 - 01:31:10 EST


On Tue, Aug 24, 2010 at 12:25:01PM -0400, Jeff Mahoney wrote:
> Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
> arguments to execve but missed the s390 prototype.
>
> This patch fixes it up.
>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
> ---
>
> arch/s390/kernel/entry.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/s390/kernel/entry.h
> +++ b/arch/s390/kernel/entry.h
> @@ -42,8 +42,8 @@ long sys_clone(unsigned long newsp, unsi
> int __user *parent_tidptr, int __user *child_tidptr);
> long sys_vfork(void);
> void execve_tail(void);
> -long sys_execve(const char __user *name, char __user * __user *argv,
> - char __user * __user *envp);
> +long sys_execve(const char __user *name, const char __user *const __user *argv,
> + const char __user *const __user *envp);
> long sys_sigsuspend(int history0, int history1, old_sigset_t mask);
> long sys_sigaction(int sig, const struct old_sigaction __user *act,
> struct old_sigaction __user *oact);

A similar patch just got merged. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/