Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio

From: KOSAKI Motohiro
Date: Thu Aug 26 2010 - 00:22:30 EST


> > writeback: remove the internal 5% low bound on dirty_ratio
> >
> > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%.
> > This is not a user expected behavior. And it's inconsistent with
> > calc_period_shift(), which uses the plain vm_dirty_ratio value.
> >
> > Let's rip the internal bound.
> >
> > At the same time, fix balance_dirty_pages() to work with the
> > dirty_thresh=0 case. This allows applications to proceed when
> > dirty+writeback pages are all cleaned.
>
> And ">" fits with the name "exceeded" better than ">=" does. I think it is
> an aesthetic improvement as well as a functional one.
>
> Reviewed-by: NeilBrown <neilb@xxxxxxx>

I agree :)
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/