[PATCH] i915: build error

From: Mark Stanovich
Date: Thu Aug 26 2010 - 11:38:31 EST


Not sure if I put the select VGA_ARB in the correct order for the Kconfig file.

When building 2.6.36-rc2, the following error occurs:

ERROR: "vga_get" [drivers/gpu/drm/i915/i915.ko] undefined!
ERROR: "vga_put" [drivers/gpu/drm/i915/i915.ko] undefined!
make[1]: *** [__modpost] Error 1

This is due to commit 9cce37f4855a30cc7c364edf18522282782f7ddc
which adds a use of function vga_put and vga_get in
drivers/gpu/drm/i915/intel_display.c. vga_put and vga_get are is
defined in file drivers/gpu/vga/vgaarb.c. To ensure that this
file is built, select VGA_ARB when DRM_I915 is selected. If
DRM_I915 is selected without VGA_ARB, a build error will occur.

Signed-off-by: Mark Stanovich <mrktimber@xxxxxxxxx>
---
drivers/gpu/drm/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4cab0c6..8f0a08b 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -98,6 +98,7 @@ config DRM_I915
tristate "i915 driver"
depends on AGP_INTEL
select SHMEM
+ select VGA_ARB
select DRM_KMS_HELPER
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/