Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions

From: Liam Girdwood
Date: Fri Aug 27 2010 - 08:25:12 EST


On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> I think this is a typo, debugfs_pop_time should not be executable.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 65352c7..42542e0 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
> printk(KERN_WARNING
> "ASoC: Failed to create codec register debugfs file\n");
>
> - codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
> + codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
> codec->debugfs_codec_root,
> &codec->pop_time);
> if (!codec->debugfs_pop_time)

Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/