Re: [PATCH] vmscan: prevent background aging of anon page in no swapsystem

[Rik van Riel]

On 08/29/2010 05:23 PM, Ying Han wrote:
> On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel<riel@xxxxxxxxxx>  wrote:
> > On 08/29/2010 01:45 PM, Ying Han wrote:
> >
> > > There are few other places in vmscan where we check nr_swap_pages and
> > > inactive_anon_is_low. Are we planning to change them to use
> > > total_swap_pages
> > > to be consistent ?
> >
> > If that makes sense, maybe the check can just be moved into
> > inactive_anon_is_low itself?
>
> That was the initial patch posted, instead we changed to use
> total_swap_pages instead. How this patch looks:

Looks good to me.  It could use a comment along the lines of:

	/*
	 * No sense scanning the anon lists if we have no swap space.
	 */

... and, of course, your signed-off-by :)

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/