RE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache

[Dan Magenheimer]

> > @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super
> >  	} else {
> >  		ext3_msg(sb, KERN_INFO, "using internal journal");
> >  	}
> > +	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
> 
> Do you really need to pass in the page size?  What about just
> "cleancache_init_fs(sb)" rather than exposing the
> "sb->cleancache_poolid"?  In other words, what if you want to do
> more/other per-filesystem init at some point?

IIRC, I think I was trying to stay away from including
fs.h in cleancache.h (or one of its predecessors).  I
agree that that no longer makes sense and it is cleaner
as you suggest.  Will change.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/