Re: ftrace/perf_event leak

From: Avi Kivity
Date: Wed Sep 01 2010 - 05:26:37 EST


On 09/01/2010 12:04 PM, Peter Zijlstra wrote:

Does something like the below cure that?


Unfortunately not.

I seem to remember C doesn't make any promises about the order of logic
statements, hence we need to explicitly pull out that try_module_get()
so that it evaluates after the rest of the conditions.

&& and || are executed in order (so you can write

if (p && p->x)

).

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/