Re: [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_bufferscatter list - RESEND

From: Hank Janssen
Date: Wed Sep 01 2010 - 13:36:04 EST


On 09/01/2010 09:38 AM, Joe Perches wrote:
> On Tue, 2010-08-31 at 11:13 -0700, Hank Janssen wrote:
>
>> diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
> []
>> - request->DataBuffer.PfnArray[i] =
>> - page_to_pfn(sg_page((&sgl[i])));
>> + request->DataBuffer.PfnArray[i] =
>> + page_to_pfn(sg_page((&sgl[i])));
>
> I did a bit of a doubletake reading this last change.
>
> This isn't actually a part of your fix and it introduces
> a whitespace error.
>

I will resubmit this patch and clean up the whitespace error.

When change the code I normally also change the indentation to the
correct format for that area of the code. That is how the whitespace
snuck in there.

Thanks,

Hank.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/