Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB inip_fragment

From: Herbert Xu
Date: Wed Sep 01 2010 - 19:31:10 EST


On Wed, Sep 01, 2010 at 02:46:58PM -0700, David Miller wrote:
.
> Therefore I'm inclined to agree with Herbert that we need to parse the
> options explicitly before invoke ip_fragment(). We must call it with
> an SKB in the state it expects, and that means with options parsing
> already performed.

FWIW the packet probably doesn't even have IP options. What is
happening here is that we've found yet another entry point from
the bridge driver into the IP stack so we need to duplicate my
original patch here.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/