Re: [PATCH v2] vmscan: prevent background aging of anon page in noswap system
From: Minchan Kim
Date: Thu Sep 02 2010 - 11:34:11 EST
Will fix.
Thanks for the quick response. Rik.
On Fri, Sep 3, 2010 at 12:16 AM, Rik van Riel <riel@xxxxxxxxxx> wrote:
> On 09/02/2010 11:12 AM, Minchan Kim wrote:
>
>> + /*
>> + * If we don't have enough swap space, anonymous page deactivation
>> + * is pointless.
>> + */
>> + if (!nr_swap_pages)
>> + return 0;
>
> It may be better to test !total_swap_pages and change the
> comment to:
>
> /*
> * If we don't have swap space, anonymous page deactivation
> * is pointless.
> */
>
> --
> All rights reversed
>
--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/