Re: [tip:x86/mm] x86, kmemcheck: Remove double test

From: Ingo Molnar
Date: Fri Sep 03 2010 - 02:25:23 EST



* Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

> On 30 August 2010 10:36, tip-bot for Julia Lawall <julia@xxxxxxx> wrote:
> > Commit-ID:  9fbaf49c7f717740002d49eee1bbd03d89d8766a
> > Gitweb:     http://git.kernel.org/tip/9fbaf49c7f717740002d49eee1bbd03d89d8766a
> > Author:     Julia Lawall <julia@xxxxxxx>
> > AuthorDate: Sat, 28 Aug 2010 17:41:03 +0200
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Mon, 30 Aug 2010 09:19:28 +0200
> >
> > x86, kmemcheck: Remove double test
> >
> > The opcodes 0x2e and 0x3e are tested for in the first Group 2
> > line as well.
> >
> > The sematic match that finds this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @expression@
> > expression E;
> > @@
> >
> > (
> > * E
> >  || ... || E
> > |
> > * E
> >  && ... && E
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
> > Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> > Cc: Vegard Nossum <vegardno@xxxxxxxxxx>
> > LKML-Reference: <1283010066-20935-5-git-send-email-julia@xxxxxxx>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > ---
> >  arch/x86/mm/kmemcheck/opcode.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
>
> Sorry, was a bit late.
>
> Thanks for the patch, review, and picking up :-)

You are welcome :)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/