Re: [PATCH] netpoll: use non-BH variant of RCU

From: Paul E. McKenney
Date: Fri Sep 03 2010 - 11:52:52 EST


On Fri, Sep 03, 2010 at 08:34:09AM -0700, David Miller wrote:
> From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> Date: Thu, 2 Sep 2010 10:26:25 -0700
>
> > softirq: adjust error check
> >
> > The error check for _local_bh_enable_ip() warns on both in_irq() and
> > irqs_disabled(). The check for in_irq() is necessary, because a hardirq
> > might well have interrupted bh execution, in which case it is simply
> > not possible for the hardirq to exclude the bh that got interrupted.
> >
> > However, it is perfectly reasonable to disable bh while hardirqs are
> > disabled, and this in fact promotes common code. This commit therefore
> > removes the irqs_disabled() check.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

Thank you, David!

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/