[PATCH 3/3] AGP: Warn when GATT memory cannot be set to UC

From: Borislav Petkov
Date: Fri Sep 03 2010 - 12:40:23 EST


From: Borislav Petkov <borislav.petkov@xxxxxxx>

This is one of those paranoid checks which should at least tell us that
something is about to go haywire after we've disabled GART table walk
probes which is done by default now on AMD.

Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
---
drivers/char/agp/generic.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index d2abf51..64255ce 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -984,7 +984,9 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)

bridge->driver->cache_flush();
#ifdef CONFIG_X86
- set_memory_uc((unsigned long)table, 1 << page_order);
+ if (set_memory_uc((unsigned long)table, 1 << page_order))
+ printk(KERN_WARNING "Could not set GATT table memory to UC!");
+
bridge->gatt_table = (void *)table;
#else
bridge->gatt_table = ioremap_nocache(virt_to_phys(table),
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/