Re: [PATCH] Revert "drm/i915: fix vblank wait test condition"

From: Chris Wilson
Date: Sat Sep 04 2010 - 05:21:17 EST


On Sat, 4 Sep 2010 11:17:14 +0300, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> This reverts commit 9559fcdbff4f93d29af04478bbc48294519424f5. The commit causes
> wrong screen resolution on some i915 machines such as MacBook which is a
> regression from 2.6.35. The issue has been reported multiple times but no fix
> has emerged:

NAK. You can't simply hide one bug by introducing a much bigger one.

As you have an affected machine, find which wait_for_vblank() needs to be
replaced with a msleep(20|50).

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/