Re: [PATCH] ARM: pxa27x_keypad: added a comment to explainclear_wakeup_event callback

[Eric Miao]

On Sun, Sep 5, 2010 at 11:33 PM, Mark F. Brown <mark.brown314@xxxxxxxxx> wrote:
> Signed-off-by: Mark F. Brown <mark.brown314@xxxxxxxxx>
> ---
> Âarch/arm/plat-pxa/include/plat/pxa27x_keypad.h | Â Â9 +++++++++
> Â1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> index 73dacda..abcc36e 100644
> --- a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> +++ b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> @@ -25,6 +25,13 @@
> Â*
> Â* 4. matrix key and direct key will use the same debounce_interval by
> Â* Â Âdefault, which should be sufficient in most cases
> + *
> + * pxa168 keypad platform specific parameter
> + *
> + * NOTE:
> + * clear_wakeup_event callback is a workaround required to clear the
> + * keypad interrupt. The keypad wake must be cleared in addition to
> + * reading the MI/DI bits in the KPC register.
> Â*/
> Âstruct pxa27x_keypad_platform_data {
>
> @@ -52,6 +59,8 @@ struct pxa27x_keypad_platform_data {
>
> Â Â Â Â/* key debounce interval */
>    Âunsigned int  Âdebounce_interval;
> +
> + Â Â Â /* clear wakeup event requirement for pxa168 */
>    Âvoid      Â(*clear_wakeup_event)(void);
> Â};
>
> --
> 1.7.0.4
>
>

Merged into below commit, and 'devel' branch pushed.

  ARM: pxa27x_keypad: added wakeup event handler for keypad interrupts

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/