Re: [PATCH] no need to align .modinfo strings

From: Jan Beulich
Date: Mon Sep 06 2010 - 04:34:59 EST


>>> On 06.09.10 at 10:19, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Thu, 2 Sep 2010 09:54:40 pm Jan Beulich wrote:
>> Their use is not performance critical, and hence it seems better to
>> save some space.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
> Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> The real question is: why is gcc aligning these? Should it be aligning

A performance consideration for those cases where strings are being
used a lot, I believe.

> any string literals at all? If so, should we look for other such wastes
> of space?

I think we should, at least I'm keeping an eye open to spot any such.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/