Re: [PATCH] Function btree_get_extent: Incorrect if-else if statement

From: Zhu Yanhai
Date: Mon Sep 06 2010 - 10:15:31 EST


This is not correct.

2010/8/9 Andrà Nogueira <andre.neo.net@xxxxxxxxx>:
> The btree_get_extent function (in file disk-io.c) calls the
> add_extent_mapping (in file extent_map.c). The add_extent_mapping
> function can return two values: 0 or -EEXIST.

It might return some other error values besides -EEXIST, the 'else if
(ret)' branch
is just against them.
Namely, we should do some thing special when EEXIST, and do another things
for all other errors.

Regards,
Zhu Yanhai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/