Re: [PATCH 5/5] MIPS: Move FIXADDR_TOP into spaces.h

[Atsushi Nemoto]

On Mon, 6 Sep 2010 21:03:52 -0700, Kevin Cernekee <cernekee@xxxxxxxxx> wrote:
> -#define FIXADDR_TOP	((unsigned long)(long)(int)0xfffe0000)
...
> +#define FIXADDR_TOP		_AC(0xfffe0000, UL)

For 64-bit kernel, FIXADDR_TOP should be 0xfffffffffffe0000UL not
0x00000000fffe0000UL.

The magical casts are used to sign-extend the address.  Please do not
drop them.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/