Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

From: venki kaps
Date: Tue Sep 07 2010 - 09:18:46 EST


Venkii,
On Tue, Sep 7, 2010 at 6:16 PM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Tue, 7 Sep 2010 11:49:38 +0900, venki kaps <venkiece2005@xxxxxxxxx>
> wrote:
>>> let me see if I understand you right. The consumption is higher
>>> when the cable is kept plugged or the consumption is higher if
>>> you boot with usb cable pugged and remove it afterwards ?
>>   >> The consumption is higher if boot without usb cable.If boot when
>> the cable is kept plugged
>>   >> and remove it afterwards, then normal.
>
> ok, so that's what I had observed and my original patch is the one
> you want. You probably _also_ want this one though due the WARN
>>> Is WARN_ON created issue? or
>>> As you mentioned earlier, if (!regulator_is_enabled(twl->usb3v1)
regulator_enable(twl->usb3v1); would be required?
>>> could you please provide more details?
>
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/