Re: [PATCH] Remove implicit list prefetches for most cases

From: Andi Kleen
Date: Wed Sep 08 2010 - 09:45:20 EST



>
> If prefetch() is generally considered a "Bad Thing",

Using it unconditionally in list_for_each style operations at least is.
>
I'm OK with just
> removing them from NetLabel; no need to rename and conditionalize. I
> put them in the netlbl_af[4,6]list_*() routines because those routines
> were modeled after the normal list routines which had prefetches and I
> just assumed someone much smarter had found them to be a win.

Unless you have gigantic list walk bodies they are unlikely to be
on anything modern.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/