Re: [tip:sched/urgent] x86, tsc: Fix a preemption leak inrestore_sched_clock_state()

From: Ingo Molnar
Date: Mon Sep 13 2010 - 04:47:14 EST



* Nico Schottelius <nico-linux-20100709@xxxxxxxxxxxxxxx> wrote:

> Good morning,
>
> tip-bot for Peter Zijlstra [Sat, Sep 11, 2010 at 07:49:07AM +0000]:
> > Commit-ID: 55496c896b8a695140045099d4e0175cf09d4eae
> > Gitweb: http://git.kernel.org/tip/55496c896b8a695140045099d4e0175cf09d4eae
> > Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > AuthorDate: Fri, 10 Sep 2010 22:32:53 +0200
> > Committer: Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Sat, 11 Sep 2010 09:47:07 +0200
> >
> > x86, tsc: Fix a preemption leak in restore_sched_clock_state()
>
> running 2.6.36-rc3-00464-g84e1d83 now, which includes that fix.
>
> So far no resume issues, but the backlight does not power on again,
> if the lid is opened.

That's probably unrelated.

> Manually triggering display backlight increase (via fn-home) changes
> it to 100% though.
>
> I've not seen that behaviour for a very long time and never on the
> X201. It has been an issue on the X200, which means probably around
> 2.6.30.

Might make sense to bisect it ... as long as you remember to do this at
every bisection step that has the hung-suspend bug:

git cherry-pick 55496c896b8a695140045099d4e0175cf09d4eae

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/