Re: [PATCH 07/17] Drop a couple of unnecessary asm/system.h inclusions

From: Geert Uytterhoeven
Date: Mon Sep 13 2010 - 13:59:51 EST


On Fri, Sep 10, 2010 at 18:10, David Howells <dhowells@xxxxxxxxxx> wrote:
> Drop inclusions of asm/system.h from linux/hardirq.h and linux/list.h as
> they're no longer required and prevent the M68K arch's IRQ flag handling macros
> from being made into inlined functions due to circular dependencies.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Acked-by: Greg Ungerer <gerg@xxxxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> ---
>
> Âinclude/linux/hardirq.h | Â Â1 -
> Âinclude/linux/list.h  Â|  Â1 -
> Â2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hardirq.h b/include/linux/hardirq.h
> index d5b3876..7dfdc06 100644
> --- a/include/linux/hardirq.h
> +++ b/include/linux/hardirq.h
> @@ -8,7 +8,6 @@
> Â#include <linux/lockdep.h>
> Â#include <linux/ftrace_irq.h>
> Â#include <asm/hardirq.h>
> -#include <asm/system.h>
>
> Â/*
> Â* We put the hardirq and softirq counter into the preemption
> diff --git a/include/linux/list.h b/include/linux/list.h
> index d167b5d..88a0006 100644
> --- a/include/linux/list.h
> +++ b/include/linux/list.h
> @@ -5,7 +5,6 @@
> Â#include <linux/stddef.h>
> Â#include <linux/poison.h>
> Â#include <linux/prefetch.h>
> -#include <asm/system.h>
>
> Â/*
> Â* Simple doubly linked list implementation.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/