Re: [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp

[Chen Gong]

ä 9/13/2010 6:17 PM, Jan Beulich åé:
> Using cpuid_eax() to determine feature availability on other than
> the current CPU is invalid. And feature availability should also be
> checked in the hotplug code path.
>
> Signed-off-by: Jan Beulich<jbeulich@xxxxxxxxxx>
> Cc: Rudolf Marek<r.marek@xxxxxxxxxxxx>
>
> ---
>   arch/x86/include/asm/cpufeature.h |    1 +
>   arch/x86/kernel/cpu/scattered.c   |    1 +
>   drivers/hwmon/coretemp.c          |   29 +++++++++++++----------------
>   3 files changed, 15 insertions(+), 16 deletions(-)
>
> --- linux-2.6.36-rc4/arch/x86/include/asm/cpufeature.h	2010-09-13 08:44:55.000000000 +0200
> +++ 2.6.36-rc4-x86-coretemp-feature-check/arch/x86/include/asm/cpufeature.h	2010-09-01 09:18:17.000000000 +0200
> @@ -168,6 +168,7 @@
>   #define X86_FEATURE_XSAVEOPT	(7*32+ 4) /* Optimized Xsave */
>   #define X86_FEATURE_PLN		(7*32+ 5) /* Intel Power Limit Notification */
>   #define X86_FEATURE_PTS		(7*32+ 6) /* Intel Package Thermal Status */
> +#define X86_FEATURE_DTS		(7*32+ 7) /* Digital Thermal Sensor */

Do we really need a new CPU flag ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/