Re: [PATCH] x86: fix duplicate calls of the nmi handler

From: Peter Zijlstra
Date: Thu Sep 16 2010 - 13:42:48 EST


On Fri, 2010-09-10 at 17:56 +0200, Robert Richter wrote:
> The commit:
>
> e40b172 x86: Move notify_die from nmi.c to traps.c
>
> moved the nmi handler call to default_do_nmi(). DIE_NMI_IPI and
> DIE_NMI are called subsequently now. If the return code is
> !NOTIFY_STOP, then the handlers are called twice. This patch fixes
> this.

What is this NMI_IPI thing, and why do we bother?

If the hardware reason thin can discriminate between IPI and other NMIs
we should never call both chains, if it cannot, why do we have 2 chains?

In any case, I don't think perf/oprofile/etc,. should use NMI_IPI, that
doesn't really make sense.

Or am I totally confused about things here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/