Re: [PATCH 0/3] BDI handling fixes

From: Christoph Hellwig
Date: Thu Sep 16 2010 - 19:47:58 EST


On Fri, Sep 17, 2010 at 12:44:08AM +0200, Jan Kara wrote:
>
> Hi,
>
> series of these three patches fixes the warning in __mark_inode_dirty()
> which happens when I do e.g. touch /dev/zero. The first two patches should
> be obvious enough and probably worth merging independently of the third
> patch. The third patch is upto a discussion whether we want to solve the
> problem that way or differently. Christoph, I know we spoke at LSF that
> inode_to_bdi() could be a per-sb method but the current version of the
> patch seems clean enough to me that we could maybe go even without the
> special callback?

Feel free to go with the simpler one. But what I think really needs to
be changes is the no writeback flag - it's exactly the wrong way around.

Instead just add a flag to allow writeback for the block device and
fs-specific bdi structures.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/