Re: Regression, bisected: reference leak with IPSec since ~2.6.31

[Eric Dumazet]

Le mardi 21 septembre 2010 Ã 09:38 +0000, Jarek Poplawski a Ãcrit :
> On Tue, Sep 21, 2010 at 11:21:00AM +0200, Eric Dumazet wrote:

> I hope you're right with this.
> 
> > 
> > I liked the :
> > 
> > <check everything without changing state>
> > if something wrong
> > 	goto slow_path
> > else
> > 	<OK, lets do destructive things>
> > 
> 
> But it's an optimization of the "unlikely" case btw. ;-)
> 

This is a bug fix, in a complex function.

in -next branch, we can try to be smart, adding more code in slow_path
to revert what was done in the hope fast path would be taken.
And pray we dont add another bug :)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/