Re: [PATCH 2/5] ACPI, APEI, Fix acpi_pre_map() return value

From: Andi Kleen
Date: Tue Sep 21 2010 - 08:47:52 EST


On Sun, Sep 19, 2010 at 11:00:32AM +0800, Huang Ying wrote:
> From: Jin Dongming <jin.dongming@xxxxxxxxxxxxxxxxxx>
>
> After we ioremap() a new region, we call __acpi_try_ioremap() to
> see whether another thread has already mapped the same region.
> This check clobbers "vaddr", so compute the return value of
> acpi_pre_map() using the ioremap() result "map->vaddr" instead.
>
> v2:
> Modified the unsuitable description of patch.
>
> v3:
> Removed unlikely() check and made description simpler.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/