Re: [PATCH 8/8] writeback: Do not sleep on the congestion queue ifthere are no congested BDIs or if significant congestion is not beingencountered in the current zone

[Andrew Morton]

On Mon, 20 Sep 2010 10:52:39 +0100
Mel Gorman <mel@xxxxxxxxx> wrote:

> > > This patch tracks how many pages backed by a congested BDI were found during
> > > scanning. If all the dirty pages encountered on a list isolated from the
> > > LRU belong to a congested BDI, the zone is marked congested until the zone
> > > reaches the high watermark.
> > 
> > High watermark, or low watermark?
> > 
> 
> High watermark. The check is made by kswapd.
> 
> > The terms are rather ambiguous so let's avoid them.  Maybe "full"
> > watermark and "empty"?
> > 
> 
> Unfortunately they are ambiguous to me. I know what the high watermark
> is but not what the full or empty watermarks are.

Really.  So what's the "high" watermark?  From the above text I'm
thinking that you mean the high watermark is when the queue has a small
number of requests and the low watermark is when the queue has a large
number of requests.

I'd have thought that this is backwards: the "high" watermark is when
the queue has a large (ie: high) number of requests.

A problem.  How do we fix it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/